-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhanced in-place update module to support vertical scaling #1353
base: master
Are you sure you want to change the base?
feat: enhanced in-place update module to support vertical scaling #1353
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
08c47c7
to
04b5eb8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
+ Coverage 47.91% 49.40% +1.49%
==========================================
Files 162 192 +30
Lines 23491 19752 -3739
==========================================
- Hits 11256 9759 -1497
+ Misses 11014 8730 -2284
- Partials 1221 1263 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0470ce2
to
4e13c0d
Compare
35c4939
to
28406cb
Compare
48126ff
to
aca435f
Compare
The complete logic needs to wait until the k8s api of kruise is upgraded. |
/hold |
aca435f
to
d064af1
Compare
d064af1
to
cbd728f
Compare
1f55de3
to
bff411c
Compare
I rebased it first, and I need to take some time to sort through the logic and fill in some tests. After all, this pr is a bit old. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some methods in VerticalUpdateInterface appear to be unimplemented.
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
…tations Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
3234854
to
88c2a0a
Compare
3f4af6f
to
a12055b
Compare
I encountered two errors while adding e2e test cases:
|
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
a12055b
to
eea019c
Compare
Ⅰ. Describe what this PR does
Enhanced the in-place update module to enable kruise's workload to modify resources without restarting the pod.
Ⅱ. Does this pull request fix one issue?
Fixes #1212
Ⅲ. Describe how to verify it
Need to kubernetes v1.27 version, and open feature gate
InPlacePodVerticalScaling
. Here is my kind configuration:Build a cloneset (or other workload that includes in-place updates) and set updateStrategy to InPlaceIfPossible. Here's an example:
Change the workload's resources, wait a while, and you'll find that the pod's resources will change, and the pod won't restart.
Ⅳ. Special notes for reviews
The control of Status for vertical scaling requires a higher version of the k8s api, which makes this pr need to wait for kruise version upgrade. It cannot be merged at this time because it is not yet complete.